sql/tests: TestRandomSyntaxSchemaChangeColumn fails due to timeout#64877
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 25, 2021
Merged
sql/tests: TestRandomSyntaxSchemaChangeColumn fails due to timeout#64877craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes: cockroachdb#63393 Previously, there was a 1 minute timeout (in team city) on the DDL alter statements run during this test under team city. With that time limit we would observe failures on certain ALTER COLUMN ADD statements, because the statement timeout could be too short. To address this, this patch bumps the random column changes statement timeout to 2 minutes, which resolves these failures. Release note: None
Member
|
This change is |
Collaborator
Author
|
bors r=postamar |
Contributor
|
Build succeeded: |
Collaborator
This was referenced May 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63393
Previously, there was a 1 minute timeout (in team city) on the DDL
alter statements run during this test under team city. With that
time limit we would observe failures on certain ALTER COLUMN ADD
statements, because the statement timeout could be too short.
To address this, this patch bumps the random column changes
statement timeout to 2 minutes, which resolves these failures.
Release note: None