Skip to content

ui: update cluster-ui version#64614

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
maryliag:column-selector
May 4, 2021
Merged

ui: update cluster-ui version#64614
craig[bot] merged 1 commit intocockroachdb:masterfrom
maryliag:column-selector

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

@maryliag maryliag commented May 3, 2021

Update cluster-ui version to include changes made on cockroachdb/ui#294 and minor fix to handle case when
no column is selected.

Release note (ui change): cluster-ui updated. Showing information about
database on Statement Page and ability to choose which columns to display.

@maryliag maryliag requested a review from a team May 3, 2021 21:38
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@Azhng Azhng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @maryliag)


pkg/ui/src/redux/localsettings.ts, line 134 at r1 (raw file):

  /**
   * Selector which retrieves this setting from the LocalSettingsState
   * and return as an array

nit: period

@maryliag maryliag force-pushed the column-selector branch 2 times, most recently from 76dc23a to 568103b Compare May 4, 2021 01:03
Update cluster-ui version and minor fix to handle case when
no column is selected.

Release note (ui change): cluster-ui updated. Showing information about
database on Statement Page and ability to choose which columns to display.
@maryliag maryliag force-pushed the column-selector branch from 568103b to dc5bc27 Compare May 4, 2021 17:30
@maryliag
Copy link
Copy Markdown
Contributor Author

maryliag commented May 4, 2021

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 4, 2021

Build succeeded:

@craig craig bot merged commit 181dd6f into cockroachdb:master May 4, 2021
@maryliag maryliag deleted the column-selector branch July 8, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants