kvserver: fix metrics collection for rejected lease requests#64531
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 4, 2021
Merged
Conversation
Previously, we were only updating the `leases.error` (metric measuring the number of failed lease requests) if a lease request failed during command evaluation. However after cockroachdb#55148, lease requests can be rejected by the replica proposal buffer if there is a known raft leader that is different from the replica requesting the lease. We were not recording such rejections as failed lease requests in the metrics. This commit fixes this oversight. Release note: None
Member
|
This change is |
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were only updating the
leases.error(metric measuring thenumber of failed lease requests) if a lease request failed during command
evaluation. However after #55148, lease requests can be rejected by the replica
proposal buffer if there is a known raft leader that is different from the
replica requesting the lease. We were not recording such rejections as failed
lease requests in the metrics.
This commit fixes this oversight.
Release note: None