build,protobuf: stop building unnecessary protobuf#64489
build,protobuf: stop building unnecessary protobuf#64489craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I was unable to automatically find a reviewer. You can try CCing one of the following members:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I was unable to automatically find a reviewer. You can try CCing one of the following members:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
rickystewart
left a comment
There was a problem hiding this comment.
The Bazel build needs to remain up-to-date.
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
rickystewart
left a comment
There was a problem hiding this comment.
The Bazel build needs to remain up-to-date.
|
@rickystewart I think this PR is ok now? |
rickystewart
left a comment
There was a problem hiding this comment.
It looks like the submodule is at 9ebd07afe83a30b9bebce6ecb1340fe6d5382134 while the version pinned in WORKSPACE is e809d75ecb5770fdc531081eef306b3e672bcdd2. They should match.
Based on cockroachdb#56 we need to avoid protobuf compiler to run for Java, Obj-C and C# everytime we build as no one is using these languages anymore. submodule c-deps/protobuf updated. Release note: None
|
bors r+ |
|
Build succeeded: |
Based on #56 we need to avoid protobuf compiler to run for Java, Obj-C and C# everytime we build as no one is using these languages anymore.
submodule c-deps/protobuf updated.
Release note: None