kvserver: remove same node check from TransferLeaseTarget#63489
kvserver: remove same node check from TransferLeaseTarget#63489craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
04e5699 to
12eb87c
Compare
aayushshah15
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @lunevalex and @nvanbenschoten)
pkg/kv/kvserver/allocator.go, line 1248 at r1 (raw file):
) roachpb.ReplicaDescriptor { sl, _, _ := a.storePool.getStoreList(storeFilterNone) sl = sl.filter(zone.VoterConstraints)
We'd want to filter by both the Constraints and VoterConstraints since are allowed to be different (and voters have to conform to both).
pkg/kv/kvserver/allocator.go, line 1389 at r1 (raw file):
sl, _, _ := a.storePool.getStoreList(storeFilterNone) sl = sl.filter(zone.Constraints)
We should filter by VoterConstraints here as well. BTW, how do you feel about lifting these VoterConstraints changes into their own commit?
|
pkg/kv/kvserver/allocator.go, line 1389 at r1 (raw file): Previously, aayushshah15 (Aayush Shah) wrote…
yeah thats a good idea, I will do a separate change for that |
In cockroachdb#51567 we added the ability to rebalance replicas between stores on the same node. This PR reverts the changes introduced in cockroachdb#12565, since we no longer need to special case multiple stores per node. Release note: None
12eb87c to
65e00f0
Compare
aayushshah15
left a comment
There was a problem hiding this comment.
Reviewable status:
nvb
left a comment
There was a problem hiding this comment.
Reviewable status:
|
TFTR! bors r+ |
|
Build succeeded: |
In #51567 we added the ability to rebalance replicas between
stores on the same node. This PR reverts the changes
introduced in #12565, since we no longer need to special case
multiple stores per node.
Release note: None