opt: fix error when crdb_internal_mvcc_timestamp used in view#63413
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 13, 2021
Merged
opt: fix error when crdb_internal_mvcc_timestamp used in view#63413craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Prior to this commit, selecting crdb_internal_mvcc_timestamp in a view caused an index out of range error since the execFactory tried to find the column in the table descriptor's PublicColumns(). This commit fixes the error by searching instead in AllColumns(). Fixes cockroachdb#62798 Release note (bug fix): Fixed an index out of range error that could occur when crdb_internal_mvcc_timestamp was selected as part of a view. It is now possible to select crdb_internal_mvcc_timestamp as part of a view as long as it is aliased with a different name.
Member
|
This change is |
mgartner
approved these changes
Apr 13, 2021
Contributor
mgartner
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @solongordon)
rytaft
commented
Apr 13, 2021
Contributor
|
Build succeeded: |
Member
|
|
Member
|
Should we backport to 21.1 and 20.2? |
Collaborator
Author
|
Yea, good call. |
This was referenced Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, selecting
crdb_internal_mvcc_timestampin a viewcaused an index out of range error since the
execFactorytried to findthe column in the table descriptor's
PublicColumns(). This commit fixesthe error by searching instead in
AllColumns().Fixes #62798
Release note (bug fix): Fixed an index out of range error that could
occur when
crdb_internal_mvcc_timestampwas selected as part of a view.It is now possible to select
crdb_internal_mvcc_timestampas part ofa view as long as it is aliased with a different name.