roachtest: stabilize splits/largerange/size=32GiB,nodes=6#63359
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 9, 2021
Merged
roachtest: stabilize splits/largerange/size=32GiB,nodes=6#63359craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit increases the snapshot recovery rate, which is important in cases where one of the followers of a large range falls behind the rest of the group and needs a raft snapshot. Additionally, it also adds a 100 second grace period to when the test waits for the large range to split into sub-ranges of the expected size. Fixes cockroachdb#61541 Release note: None
Member
|
This change is |
Contributor
Author
|
I do still plan on adding at least one variant that has non-voters but I want to stress it on my end before I add it. I'll get to that soon™. |
nvb
approved these changes
Apr 9, 2021
Contributor
nvb
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aayushshah15)
Contributor
Author
|
TFTR bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit increases the snapshot recovery rate of the test cluster,
which is important in cases where one of the followers of a large range
falls behind the rest of the group and needs a raft snapshot.
Additionally, it also adds a 100 second grace period to when the test
waits for the large range to split into sub-ranges of the expected size.
Fixes #61541
Release note: None