Skip to content

go.mod: bump etcd/raft to pick up proto size improvements#62819

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/raft-e51c697ec6e8
Mar 31, 2021
Merged

go.mod: bump etcd/raft to pick up proto size improvements#62819
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/raft-e51c697ec6e8

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Mar 30, 2021

This commit picks up etcd-io/etcd#12790, which resolves a regression observed in #62212.

Picks up the following four commits, each of which I've reviewed for safety:

name                  old time/op    new time/op    delta
EntryCache-16            114µs ± 7%      96µs ±12%  -15.29%  (p=0.000 n=19+19)
EntryCacheClearTo-16    37.7µs ± 4%    34.9µs ± 4%   -7.55%  (p=0.000 n=17+18)

name                  old alloc/op   new alloc/op   delta
EntryCacheClearTo-16    1.28kB ± 0%    0.77kB ± 0%  -40.00%  (p=0.000 n=20+20)
EntryCache-16           83.3kB ± 0%    50.0kB ± 0%  -39.95%  (p=0.000 n=19+20)

name                  old allocs/op  new allocs/op  delta
EntryCache-16             3.00 ± 0%      3.00 ± 0%     ~     (all equal)
EntryCacheClearTo-16      1.00 ± 0%      1.00 ± 0%     ~     (all equal)

@nvb nvb added the GA-blocker label Mar 30, 2021
@nvb nvb requested a review from tbg March 30, 2021 18:41
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@nvb nvb force-pushed the nvanbenschoten/raft-e51c697ec6e8 branch from 8d5d078 to cd07b7e Compare March 30, 2021 19:57
This commit picks up etcd-io/etcd#12790, which
resolves a regression observed in cockroachdb#62212.

Picks up the following four commits:
- etcd-io/etcd@87258ef
- etcd-io/etcd@2c2456b
- etcd-io/etcd@ebc0174
- etcd-io/etcd@e51c697

```
name                  old time/op    new time/op    delta
EntryCache-16            114µs ± 7%      96µs ±12%  -15.29%  (p=0.000 n=19+19)
EntryCacheClearTo-16    37.7µs ± 4%    34.9µs ± 4%   -7.55%  (p=0.000 n=17+18)

name                  old alloc/op   new alloc/op   delta
EntryCacheClearTo-16    1.28kB ± 0%    0.77kB ± 0%  -40.00%  (p=0.000 n=20+20)
EntryCache-16           83.3kB ± 0%    50.0kB ± 0%  -39.95%  (p=0.000 n=19+20)

name                  old allocs/op  new allocs/op  delta
EntryCache-16             3.00 ± 0%      3.00 ± 0%     ~     (all equal)
EntryCacheClearTo-16      1.00 ± 0%      1.00 ± 0%     ~     (all equal)
```
@nvb nvb force-pushed the nvanbenschoten/raft-e51c697ec6e8 branch from cd07b7e to 4b3b169 Compare March 30, 2021 20:18
@tbg
Copy link
Copy Markdown
Member

tbg commented Mar 31, 2021

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 31, 2021

Build failed:

@tbg
Copy link
Copy Markdown
Member

tbg commented Mar 31, 2021

bors r+

=== RUN TestImportIntoCSV/import-into-implicit-gzip
import_stmt_test.go:2891: error scanning '&{0xc0078bc360 }': pq: relation "t" is offline: importing

cc @pbardea

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 31, 2021

Build failed:

@tbg
Copy link
Copy Markdown
Member

tbg commented Mar 31, 2021

=== RUN TestImportIntoCSV/multiple-import-into-without-pk
import_stmt_test.go:3285: error scanning '&{0xc0027e6fc0 }': pq: relation "t" is offline: importing
--- FAIL: TestImportIntoCSV/multiple-import-into-without-pk (1.70s)

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 31, 2021

Build succeeded:

@craig craig bot merged commit 45f74b4 into cockroachdb:master Mar 31, 2021
@nvb nvb deleted the nvanbenschoten/raft-e51c697ec6e8 branch April 1, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants