kvserver: fix flake in TestStoreMetrics#62660
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 30, 2021
Merged
Conversation
Fixes cockroachdb#60146 When TestStoreMetrics was converted to use TestCluster in cockroachdb#59670. The verifyStats method was changed to not stop the stores anymore that was a mistake that caused this flake. This change adds back the stopping and fixes a race with lease transfers. Release note: None
Member
|
This change is |
erikgrinaker
approved these changes
Mar 27, 2021
Contributor
erikgrinaker
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @tbg)
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60146
When TestStoreMetrics was converted to use TestCluster in #59670.
The verifyStats method was changed to not stop the stores anymore
that was a mistake that caused this flake. This change adds back the
stopping and fixes a race with lease transfers.
Release note: None