sql, server: add SQLStatsResetter to distsql and internalExecutor#62617
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 26, 2021
Merged
sql, server: add SQLStatsResetter to distsql and internalExecutor#62617craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
yuzefovich
reviewed
Mar 25, 2021
Member
yuzefovich
left a comment
There was a problem hiding this comment.
LGTM but probably worth waiting for Alfonso's feedback too.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @asubiotto and @Azhng)
pkg/sql/execinfra/server_config.go, line 156 at r1 (raw file):
HydratedTables *hydratedtables.Cache // SQLStatsResetter is an interface used to reset SQL stats without introduce
nit: "without introduction" or "without the need to introduce".
a5a4269 to
c16570b
Compare
Contributor
Author
|
Rebased to pick up fix on |
Closes cockroachdb#62587. Release note: None
c16570b to
d43090e
Compare
asubiotto
approved these changes
Mar 26, 2021
Contributor
asubiotto
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:
Contributor
Author
|
TFTR! bors r=asubiotto,yuzefovich |
Contributor
|
Build succeeded: |
This was referenced May 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62587.
Release note: None