bazel: mark logictest as working in bazel#62548
bazel: mark logictest as working in bazel#62548craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
d5b2158 to
6b69820
Compare
|
|
||
| go_test( | ||
| name = "multiregionccl_test", | ||
| size = "enormous", |
There was a problem hiding this comment.
this should probably just be medium or large.
There was a problem hiding this comment.
I ran the test on my machine and it didn't conclude within 5m 🤷 https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/1553172016/How+to+ensure+your+tests+can+run+in+the+Bazel+sandbox#Test-size
There was a problem hiding this comment.
random driveby comment -- can the test runner be updated to say "Test timed out after X duration" rather than "Test timed out at time X"? i was just looking at these logs https://teamcity.cockroachdb.com/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=2810604&_focus=39520
There was a problem hiding this comment.
random driveby comment -- can the test runner be updated to say "Test timed out after X duration" rather than "Test timed out at time X"?
Probably, but that's not happening immediately -- we haven't made any adjustments to the test runner at all so far, although that's on the roadmap.
Also bump some test sizes to avoid timeouts. Resolves cockroachdb#61917 Release note: None
|
Failures look like flakes. bors r+ |
|
👎 Rejected by label |
|
bors r+ |
|
Build succeeded: |
Release note: None