Skip to content

build: perform bazel clean --expunge on make clean#62009

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:make_clean
Mar 22, 2021
Merged

build: perform bazel clean --expunge on make clean#62009
craig[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:make_clean

Conversation

@rickystewart
Copy link
Copy Markdown
Collaborator

Release note: None

@rickystewart rickystewart requested a review from rail March 15, 2021 14:50
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

Copy link
Copy Markdown
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@rickystewart
Copy link
Copy Markdown
Collaborator Author

bazel isn't installed in every context from which we run make clean, so I put this behind a conditional.

@rickystewart
Copy link
Copy Markdown
Collaborator Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 22, 2021

Build succeeded:

@craig craig bot merged commit 7899744 into cockroachdb:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants