kvserver: stop spuriously refusing non-voters in replicateQueue.shouldQueue()#61967
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 22, 2021
Merged
Conversation
Member
|
This change is |
andreimatei
reviewed
Mar 15, 2021
Contributor
andreimatei
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
nvb
approved these changes
Mar 16, 2021
e0d950d to
4d2dbd0
Compare
Contributor
Author
Added a test, PTAL. |
31e4c0c to
54bf0e0
Compare
nvb
approved these changes
Mar 22, 2021
Contributor
nvb
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:
…ldQueue()` Before this commit, the `replicateQueue` would refuse to queue up a replica into the queue (in its `shouldQueue` method) for the rebalancing case unless it could verify that a voting replica needed to be rebalanced. This was an unfortunate oversight since it meant that unless there was a voting replica to be rebalanced, non-voters would not get rebalanced by the queue. This commit fixes this bug. Noticed while debugging a flakey test for cockroachdb#61682 Release justification: bug fix Release note: None
54bf0e0 to
1961be1
Compare
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, the
replicateQueuewould refuse to queue up areplica into the queue (in its
shouldQueuemethod) for the rebalancingcase unless it could verify that a voting replica needed to be
rebalanced. This was an unfortunate oversight since it meant that unless
there was a voting replica to be rebalanced, non-voters would not get
rebalanced by the queue.
This commit fixes this bug.
Noticed while debugging a flakey test for #61682
Release justification: bug fix
Release note: None