[dnm] roachprod: start crdb in a container#61901
Closed
tbg wants to merge 1 commit intocockroachdb:masterfrom
Closed
[dnm] roachprod: start crdb in a container#61901tbg wants to merge 1 commit intocockroachdb:masterfrom
tbg wants to merge 1 commit intocockroachdb:masterfrom
Conversation
This isn't something I am planning to finish, but I wanted to see if I would immediately run into any snags when trying to get `roachprod start` to spin up a Docker container instead of running bare-metal. The motivation is twofold: - I'm generally interested in how we involve roachprod over time. Specifically, the question is whether in the long run systems testing should be done in k8s and which, if any, stepping stones there are to evolve what we currently do into that direction. - The current bare-metal setup goes [unresponsive] when CRDB goes into overdrive, and tests fail in the most opaque ways. We then incur a large tax for debugging these situations since we can't access the cluster in that state. Work that would need to be done to really finish this: - maintain ubuntu images that come with docker installed (right now needs to be manually set up) and the `ubuntu` user set up and the images we need cached - we hit the old problem of having to pass the uid/gid to the container to avoid creating files as root, I hacked around it by hard-coding them - Setting the cluster settings, etc, is all done via the `./cockroach` binary but that is no longer a thing. Ideally that should use SQL - The whole premise of uploading binaries is out of the window, we need to deal in CRDB containers exclusively, though we could conceivably use a wrapper container running the uploaded binary if we wanted to retain how roachprod/test work. [unresponsive]: cockroachdb#59424 (comment) Release note: None
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't something I am planning to finish, but I wanted to see if I
would immediately run into any snags when trying to get
roachprod startto spin up a Docker container instead of running bare-metal.The motivation is twofold:
Specifically, the question is whether in the long run systems testing
should be done in k8s and which, if any, stepping stones there are to
evolve what we currently do into that direction.
overdrive, and tests fail in the most opaque ways. We then incur a
large tax for debugging these situations since we can't access the
cluster in that state.
Work that would need to be done to really finish this:
needs to be manually set up) and the
ubuntuuser set up and the imageswe need cached
to avoid creating files as root, I hacked around it by hard-coding
them
./cockroachbinary but that is no longer a thing. Ideally that should use SQL
need to deal in CRDB containers exclusively, though we could
conceivably use a wrapper container running the uploaded binary
if we wanted to retain how roachprod/test work.
cc @irfansharif
Release note: None