sql/catalog/lease: revert fallback change and fallback also when doing by-id lookups#61493
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Mar 9, 2021
Merged
Conversation
Member
|
This change is |
postamar
approved these changes
Mar 8, 2021
…ptors" This reverts commit e3f09d5. Release justification: Release note (<category, see below>): <what> <show> <why>
…riptor This fallback is potentially expensive but it turns out to be crucial. I'm somewhat sad about it but this is a pretty bad bug that very much breaks the schemachange workload. Release justification: bug fixes and low-risk updates to new functionality Release note: None
69e6af3 to
f09203f
Compare
ajwerner
commented
Mar 9, 2021
Contributor
Author
ajwerner
left a comment
There was a problem hiding this comment.
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #59606 and then adds the parallel fallback logic to the
ByIDresolution path. It was uncovered by the schema change workload. In particular, we were missing out on the ability to do AS OF SYSTEM TIME reads on dropped schemas or types after they had been fully dropped.Fixes #57487.
Release justification: bug fixes and low-risk updates to new functionality
Release note: None