Skip to content

sql: add estimated row count to all operators in EXPLAIN#61344

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
RaduBerinde:explain-est-rows
Mar 3, 2021
Merged

sql: add estimated row count to all operators in EXPLAIN#61344
craig[bot] merged 1 commit intocockroachdb:masterfrom
RaduBerinde:explain-est-rows

Conversation

@RaduBerinde
Copy link
Copy Markdown
Member

This change adds the estimated row count to all operators in the
vanilla EXPLAIN, as long as the tables involved had statistics.

Fixes #61310.

Release justification: bug fixes and low-risk updates to new functionality

Release note (sql change): EXPLAIN now shows estimated row counts for
all operators even without VERBOSE (except when we don't have
statistics for the tables).

@RaduBerinde RaduBerinde requested review from mgartner and rytaft March 2, 2021 16:59
@RaduBerinde RaduBerinde requested a review from a team as a code owner March 2, 2021 16:59
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 17 of 17 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

Copy link
Copy Markdown
Contributor

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 17 of 17 files at r1.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained

This change adds the estimated row count to all operators in the
vanilla EXPLAIN, as long as the tables involved had statistics.

Fixes cockroachdb#61310.

Release justification: bug fixes and low-risk updates to new functionality

Release note (sql change): EXPLAIN now shows estimated row counts for
all operators even without VERBOSE (except when we don't have
statistics for the tables).
@RaduBerinde
Copy link
Copy Markdown
Member Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 2, 2021

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 3, 2021

Build succeeded:

@craig craig bot merged commit 50641ee into cockroachdb:master Mar 3, 2021
@RaduBerinde RaduBerinde deleted the explain-est-rows branch March 8, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: add estimated rows to all EXPLAIN operators

4 participants