tracing: don't return an error from ImportRemoteSpans#61327
Merged
craig[bot] merged 1 commit intomasterfrom Mar 8, 2021
Merged
tracing: don't return an error from ImportRemoteSpans#61327craig[bot] merged 1 commit intomasterfrom
craig[bot] merged 1 commit intomasterfrom
Conversation
Member
|
This change is |
erikgrinaker
approved these changes
Mar 2, 2021
Contributor
erikgrinaker
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @angelapwen, @irfansharif, and @knz)
angelapwen
approved these changes
Mar 2, 2021
angelapwen
left a comment
There was a problem hiding this comment.
Looks good to me as well!
Reviewable status:
Member
Author
|
bors r=erikgrinaker,angelapwen |
Contributor
|
Build failed: |
Member
Author
|
bors r=erikgrinaker,angelapwen sql package + race detector = too much work and goes boom Let's try again |
Contributor
|
Build failed: |
We no longer return errors from ImportRemoteSpans, and we saw in the [past] that it is not a good idea to do so - it's easy to mess up cross-version behavior. [past]: #59992 (comment) Release justification: low-risk code clarification Release note: None
0b9934b to
4c76e19
Compare
Member
Author
|
Third time's the charm bors r=erikgrinaker,angelapwen |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer return errors from ImportRemoteSpans, and we saw in the
past that it is not a good idea to do so - it's easy to mess up
cross-version behavior.
Release justification: low-risk code clarification
Release note: None