server: token-based Add/Join functionality#61265
Draft
aaron-crl wants to merge 3 commits intocockroachdb:masterfrom
Draft
server: token-based Add/Join functionality#61265aaron-crl wants to merge 3 commits intocockroachdb:masterfrom
aaron-crl wants to merge 3 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
f1be87c to
193a853
Compare
7513117 to
fb19b5b
Compare
aaron-crl
commented
Mar 4, 2021
Author
aaron-crl
left a comment
There was a problem hiding this comment.
@itsbilal , I'll rebase this off of #61505 or #61512 once they land.
Otherwise I've squashed things to make things easier on both of us.
I've got stubs which can be replaced with the functions you've already written so feel free to take a look but I'll need to do that rebase before this code settles.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @itsbilal and @knz)
aaron-crl
commented
Mar 5, 2021
Author
aaron-crl
left a comment
There was a problem hiding this comment.
Rebased on top of the current version of #61512
Reviewable status:
1e46a96 to
ca0e3ac
Compare
added 3 commits
March 5, 2021 18:16
* added new protobuf message for add/join protocol * added CLI command for testing add/join protocol * added authentication bypass for add/join GRPC endpoint * added GRP client and server functions for add/join protocol * removed config dependcy from cert init code where SSLCertDir was fine * added add/join protocol specific dial options helper in rpc package Release justification: low, completing functionality behind separate cli command Release note: None
* removed stubs and dummy functions * cleaned up TODOs Release justification: low risk, feature flagged functional enhancement Release note: None
5e7424e to
1b6f8ff
Compare
Member
|
Aaron Blum seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for add/join handshake development.
Part of #60632
Release justification: None
Release note: None