util/log: ensure that all channel logs are displayed with -show-logs#61237
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 1, 2021
Merged
util/log: ensure that all channel logs are displayed with -show-logs#61237craig[bot] merged 1 commit intocockroachdb:masterfrom
-show-logs#61237craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
tbg
approved these changes
Mar 1, 2021
Member
tbg
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @itsbilal)
When `-show-logs` is specified, the `log.Scope` becomes a no-op and the default configuration in the `log` package is used. This is the only time ever when the default configuration is used. Prior to this patch, only the logging for the DEV channel would make its way to the standard error (and the test output) in that case. This was unfortunate, since the intent (as spelled out in a comment already) was to display everything. This patch fixes that. Release justification: non-production code changes Release note: None
ee0a0d0 to
a3d35c8
Compare
Contributor
Author
|
TFYR! bors r=tbg |
Contributor
|
Build failed: |
Contributor
Author
|
bors r=tbg |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
-show-logsis specified, thelog.Scopebecomes a no-op andthe default configuration in the
logpackage is used. This is theonly time ever when the default configuration is used.
Prior to this patch, only the logging for the DEV channel would
make its way to the standard error (and the test output) in that
case. This was unfortunate, since the intent (as spelled out in a
comment already) was to display everything.
This patch fixes that.
Release justification: non-production code changes
Release note: None