distsql: improve test harness for processors against operators#60648
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 17, 2021
Merged
distsql: improve test harness for processors against operators#60648craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
asubiotto
approved these changes
Feb 17, 2021
Contributor
asubiotto
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Previously, when comparing the output of processors and operators, if any order is allowed, we would perform a quadratic search. This is suboptimal, and this commit improves the situation by sorting both outputs first and then using the ordered comparison. Additionally, this commit fixes a rare flake when seemingly the same outputs would result in a mismatch. I could somewhat reliably reproduce it before the patch and cannot reproduce it after the patch. It is likely to do something with the float comparison, but I didn't get to the bottom of the flake, yet I don't think it's worth it given that this commit improves the situation anyway. Release note: None
99694e2 to
7989683
Compare
Member
Author
|
I needed to make a slight adjustment so that we sort only on TFTR! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when comparing the output of processors and operators, if
any order is allowed, we would perform a quadratic search. This is
suboptimal, and this commit improves the situation by sorting both
outputs first and then using the ordered comparison.
Additionally, this commit fixes a rare flake when seemingly the same
outputs would result in a mismatch. I could somewhat reliably reproduce
it before the patch and cannot reproduce it after the patch. It is
likely to do something with the float comparison, but I didn't get to
the bottom of the flake, yet I don't think it's worth it given that this
commit improves the situation anyway.
Fixes: #60608.
Release note: None