backupccl: update backup detached tests with retry execution under transaction#60512
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 17, 2021
Merged
Conversation
Member
|
This change is |
pbardea
approved these changes
Feb 17, 2021
Contributor
pbardea
left a comment
There was a problem hiding this comment.
LGTM with a minor nit. Thanks!
pbardea
reviewed
Feb 17, 2021
Contributor
pbardea
left a comment
There was a problem hiding this comment.
Ah -- my comment from my previous review got swallowed.
pbardea
reviewed
Feb 17, 2021
…ansaction Previously, backup and restore detached tests do not retry if transactions fail. They could be flaky tests and fail in CI check. With this PR, backup and restore detached tests under transaction will not be aborted by retry errors. Release note: None.
0a17027 to
f61a102
Compare
Contributor
Author
|
TFTR! bors r=pbardea |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update backup and restore detached tests with retry execution under transaction
Previously, backup and restore detached tests do not retry if transactions fail. They could be flaky tests and fail in CI check.
With this PR, backup and restore detached tests under transaction will not be aborted by retry errors.
Release notes: None.