bazel: quash unnecessary dependency on pkg/util/uuid from protos#60441
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 10, 2021
Merged
bazel: quash unnecessary dependency on pkg/util/uuid from protos#60441craig[bot] merged 1 commit intocockroachdb:masterfrom
pkg/util/uuid from protos#60441craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This dependency can be replaced with a few `# keep` deps in a few choice proto targets, which is what we should have done the whole time anyway. This fixes build failures elsewhere in tree -- for example, `pkg/util/uuid:uuid_test`, which doesn't play nicely with `rules_go` in the presence of this dependency. Fixes cockroachdb#59778. Release note: None
Member
|
This change is |
irfansharif
approved these changes
Feb 10, 2021
Contributor
irfansharif
left a comment
There was a problem hiding this comment.
Hm, I'm pretty sure I've fought this exact same fight before, and even then I'm pretty sure I was confused by the _test packages. Deja vu.
Collaborator
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This dependency can be replaced with a few
# keepdeps in a few choiceproto targets, which is what we should have done the whole time anyway.
This fixes build failures elsewhere in tree -- for example,
pkg/util/uuid:uuid_test, which doesn't play nicely withrules_gointhe presence of this dependency.
Fixes #59778.
Release note: None