Skip to content

tree: correct StatementTag of ALTER TABLE ... LOCALITY#59747

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:statement_locality
Feb 3, 2021
Merged

tree: correct StatementTag of ALTER TABLE ... LOCALITY#59747
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:statement_locality

Conversation

@otan
Copy link
Copy Markdown
Contributor

@otan otan commented Feb 3, 2021

Release note: None

@otan otan requested review from a team and ajstorm February 3, 2021 06:06
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @otan)


pkg/sql/sem/tree/stmt.go, line 215 at r1 (raw file):

// StatementTag returns a short string identifying the type of statement.
func (*AlterTableLocality) StatementTag() string { return "ALTER TABLE LOCALITY" }

Nit: ALTER TABLE SET LOCALITY

@otan otan force-pushed the statement_locality branch from c291647 to 8c52149 Compare February 3, 2021 19:33
@otan
Copy link
Copy Markdown
Contributor Author

otan commented Feb 3, 2021

done

bors r=ajstorm

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 3, 2021

Build succeeded:

@craig craig bot merged commit cb9d41c into cockroachdb:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants