streamingest: add job level test for stream ingestion#59588
streamingest: add job level test for stream ingestion#59588craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
| ) | ||
|
|
||
| // Dummy import to pull in kvtenantccl. This allows us to start tenants. | ||
| var _ = kvtenantccl.Connector{} |
There was a problem hiding this comment.
I think we can do this with an import line that looks like:
_ "github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvtenantccl"
665b56d to
a06e6cd
Compare
adityamaru
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @pbardea)
pkg/ccl/streamingccl/streamingest/stream_ingestion_test.go, line 45 at r4 (raw file):
Previously, pbardea (Paul Bardea) wrote…
I think we can do this with an import line that looks like:
_ "github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvtenantccl"
Done.
pkg/sql/parser/parse_test.go, line 1724 at r4 (raw file):
Previously, pbardea (Paul Bardea) wrote…
Let's also add some tests for
RESTORE TABLE foo FROM ...since it's supported by the grammar. Although we error on it later, I think it's worth noting in these tests that it's a grammar that we support. A comment along with the tests explaining that we'll error out later would be good too.
Done.
|
Going to wait for your timer change to merge before I check this in, but this should be RFAL! |
| @@ -0,0 +1,65 @@ | |||
| // Copyright 2018 The Cockroach Authors. | |||
82b5968 to
2d0f616
Compare
This change adds a test that exercises all the components of the stream ingestion flow. It fixes some missing pieces that were discovered while writing the test. Release note: None
2d0f616 to
aa6c8b5
Compare
|
TFTR! bors r=pbardea |
|
Build succeeded: |
This change adds a test that exercises all the components of the stream
ingestion flow. It fixes some missing pieces that were discovered while
writing the test.
Informs: #59175
Release note: None