colexec,bazel: pin the types dependency in generated files#59536
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 28, 2021
Merged
colexec,bazel: pin the types dependency in generated files#59536craig[bot] merged 1 commit intocockroachdb:masterfrom
types dependency in generated files#59536craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
rickystewart
approved these changes
Jan 28, 2021
Collaborator
|
Looks like you have to |
This is a workaround for bazel auto-generated code. goimports does not automatically pick up the right packages when run within the bazel sandbox, so we have to pin it by hand. Release note: None
9cf76de to
0d79e70
Compare
Contributor
Author
|
Heh, bitten by our own footguns. TFTR! bors r+ |
alan-mas
approved these changes
Jan 28, 2021
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for bazel auto-generated code. goimports does not
automatically pick up the right packages when run within the bazel
sandbox, so we have to pin it by hand.
Release note: None