build,bazel: remove references to gofmt in bazel build#59388
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 25, 2021
Merged
build,bazel: remove references to gofmt in bazel build#59388craig[bot] merged 1 commit intocockroachdb:masterfrom
gofmt in bazel build#59388craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This was cargo-culted from the `Makefile`, but isn't necessary to get the build to succeed, and interferes with hermiticity because it requires `gofmt` to be globally installed. It's simpler to just remove these references entirely. Release note: None
Member
|
This change is |
alan-mas
approved these changes
Jan 25, 2021
Collaborator
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was cargo-culted from the
Makefile, but isn't necessary to getthe build to succeed, and interferes with hermiticity because it
requires
gofmtto be globally installed. It's simpler to just removethese references entirely.
Release note: None