[prototype] tracing: centralize storage of structured events#59310
Closed
irfansharif wants to merge 2 commits intocockroachdb:masterfrom
Closed
[prototype] tracing: centralize storage of structured events#59310irfansharif wants to merge 2 commits intocockroachdb:masterfrom
irfansharif wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Member
...into it's own thing. We're still working out exactly how structured payloads are stored, how their ownership flows internally. See the recent discussion in cockroachdb#59145 for our state of confusion. Release note: None
I think it'll make addressing questions like cockroachdb#59145 easier. By disaggregating storage from the spans themselves, questions around "consuming" tracing events are a bit simpler to reason about. I think we'll want to do something like this anyway if we want to cap the total memory usage of structured events across active spans. Release note: None
This was referenced Jan 22, 2021
b7e8569 to
8a2086f
Compare
Contributor
Author
|
Nothing we'll get to soon, we're too close to the stability cutoff. I still think this is a good idea in general, and something we should move towards. It's a small change, and makes a few things a bit more natural:
|
Contributor
Author
|
Another perk of having span-centric storage comes from #61353. At the time of writing, only root spans are accessible through the registry. So a built-in that's able to selectively toggle the verbosity of a span is of limited use; we can't isolate a random child span because it's only indirectly accessible (we'd need to traverse the tree of the root span). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it'll make addressing questions like #59145 easier. By
disaggregating storage from the spans themselves, questions around
"consuming" tracing events are a bit simpler to reason about. I think
we'll want to do something like this anyway if we want to cap the total
memory usage of structured events across active spans.
Release note: None