execstats: add cumulative contention time to the TraceAnalyzer#59299
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 1, 2021
asubiotto:tact
Merged
execstats: add cumulative contention time to the TraceAnalyzer#59299craig[bot] merged 1 commit intocockroachdb:masterfrom asubiotto:tact
craig[bot] merged 1 commit intocockroachdb:masterfrom
asubiotto:tact
Conversation
Member
|
This change is |
RaduBerinde
approved these changes
Jan 22, 2021
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
This commit adds the summing of each processor's contention time to the TraceAnalyzer. This stat is returned as a node and query level stat. Additionally, this commit adds a ContentionTime field to the StatementStatistics protobuf used in the DB Console. Release note: None
Contributor
Author
|
bors r=RaduBerinde |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #59132
Closes #56797
This commit adds the summing of each processor's contention time to the
TraceAnalyzer. This stat is returned as a node and query level stat.
Additionally, this commit adds a ContentionTime field to the
StatementStatistics protobuf used in the DB Console.
Release note: None