opt: deflake distsql_automatic_stats#59273
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 22, 2021
Merged
Conversation
This test recently started running with some metamorphic constants enabled and it flakes. The failure mode suggests that multiple stat jobs run in-between two retry iterations. This change fixes the test to use queries that only show the latest statistics; this tolerates extra stat collection jobs. Fixes cockroachdb#59263. Fixes cockroachdb#56700. Release note: None
Member
|
This change is |
otan
approved these changes
Jan 22, 2021
Contributor
otan
left a comment
There was a problem hiding this comment.
LGTM, i'm gonna merge this because i'm having a flaky day
bors r+ p=9999 single=on
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test recently started running with some metamorphic constants
enabled and it flakes. The failure mode suggests that multiple stat
jobs run in-between two retry iterations. This change fixes the test
to use queries that only show the latest statistics; this tolerates
extra stat collection jobs.
Fixes #59263.
Fixes #56700.
Release note: None