Skip to content

opt: fix autocommit_nonmetamorphic#59193

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
RaduBerinde:fix-autocommit-nonmetamorphic
Jan 20, 2021
Merged

opt: fix autocommit_nonmetamorphic#59193
craig[bot] merged 1 commit intocockroachdb:masterfrom
RaduBerinde:fix-autocommit-nonmetamorphic

Conversation

@RaduBerinde
Copy link
Copy Markdown
Member

@RaduBerinde RaduBerinde commented Jan 20, 2021

Another instance of a test that was not updated because it didn't run
in the original CI or bors run.

Release note: None

@RaduBerinde
opt: fix autocommit_nonmetamorphic
d252400 
Another instance of a test that was not updated because it didn't run
in the original CI or bors run.

Release note: None
@RaduBerinde RaduBerinde requested a review from nvb January 20, 2021 14:52
@RaduBerinde RaduBerinde requested a review from a team as a code owner January 20, 2021 14:52
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jan 20, 2021

This change is Reviewable

@RaduBerinde
Copy link
Copy Markdown
Member Author

RaduBerinde commented Jan 20, 2021

git bisect points to #58897
@irfansharif is it expected to get extra CPuts with that change?

@RaduBerinde
Copy link
Copy Markdown
Member Author

RaduBerinde commented Jan 20, 2021

Ah, I guess it's not extra operations, just the same operations that now show up twice in the trace? Seems like a bug? Still, we should get this in ASAP so we can deflake the test.

@irfansharif
Copy link
Copy Markdown
Contributor

irfansharif commented Jan 20, 2021

Hm, yea definitely not intentional. Now that tracing is always enabled, perhaps it's surfacing an underlying bug that results in doubly capturing the same traces. I'll investigate separately.

@irfansharif irfansharif mentioned this pull request Jan 20, 2021
Closed
@RaduBerinde
Copy link
Copy Markdown
Member Author

RaduBerinde commented Jan 20, 2021

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 20, 2021

Build succeeded:

@craig craig bot merged commit 664e4a0 into cockroachdb:master Jan 20, 2021
@RaduBerinde RaduBerinde deleted the fix-autocommit-nonmetamorphic branch January 20, 2021 19:02
@adityamaru
Copy link
Copy Markdown
Contributor

adityamaru commented Jan 20, 2021

I'm not sure this fixed it, I'm still seeing the test flake (with the expected output being what was before this change) - https://teamcity.cockroachdb.com/viewLog.html?buildId=2600096&buildTypeId=Cockroach_UnitTests

@pbardea
Copy link
Copy Markdown
Contributor

pbardea commented Jan 20, 2021

@adityamaru I don't think that commit included this change.

@adityamaru
Copy link
Copy Markdown
Contributor

adityamaru commented Jan 20, 2021

oops, ignore me, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvb nvb Awaiting requested review from nvb

1 more reviewer

@irfansharif irfansharif irfansharif approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RaduBerinde @cockroach-teamcity @irfansharif @adityamaru @pbardea