opt: build stats and logical props for multi-column inverted joins#59171
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jan 20, 2021
Merged
Conversation
The statistics builder was updated in cockroachdb#58054 to consider constant filters on non-inverted prefix columns when building stats for multi-column inverted joins. This commit adds additional tests for this. There is no release note because multi-column inverted indexes are gated behind the `experimental_enable_multi_column_inverted_indexes` session setting. Release note: None
Member
|
This change is |
…props This commit updates the logical props builder to consider inverted join prefix key columns when building logical props for inverted join expressions. There is no release note because multi-column inverted indexes are gated behind the `experimental_enable_multi_column_inverted_indexes` session setting. Release note: None
3459e80 to
62ddee7
Compare
mgartner
commented
Jan 20, 2021
| } | ||
| tn = tree.NewUnqualifiedTableName("t2") | ||
| tab = md.AddTable(tc.Table(tn), tn) | ||
| inputTab := md.AddTable(tc.Table(tn), tn) |
Contributor
Author
There was a problem hiding this comment.
I had to create a new variable rather than reuse tab so that the reference to tab in the InvertedJoinPrivate below is the correct table—the one with the inverted index.
rytaft
approved these changes
Jan 20, 2021
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 5 of 5 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained
Contributor
Author
|
TFTR! bors r=rytaft |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opt: add stats tests for multi-column inverted joins
The statistics builder was updated in #58054 to consider constant
filters on non-inverted prefix columns when building stats for
multi-column inverted joins. This commit adds additional tests for this.
There is no release note because multi-column inverted indexes are gated
behind the
experimental_enable_multi_column_inverted_indexessessionsetting.
Release note: None
opt: consider inverted join prefix key columns when building logical props
This commit updates the logical props builder to consider inverted join
prefix key columns when building logical props for inverted join
expressions.
There is no release note because multi-column inverted indexes are gated
behind the
experimental_enable_multi_column_inverted_indexessessionsetting.
Release note: None