Skip to content

ui: upgrade admin-ui-components to new dep#59141

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
dhartunian:upgrade-admin-ui-components-to-cluster-ui
Jan 25, 2021
Merged

ui: upgrade admin-ui-components to new dep#59141
craig[bot] merged 1 commit intocockroachdb:masterfrom
dhartunian:upgrade-admin-ui-components-to-cluster-ui

Conversation

@dhartunian
Copy link
Copy Markdown
Collaborator

We renamed the admin-ui-components package
to cluster-ui.

Release note: None

@dhartunian dhartunian requested a review from a team January 19, 2021 15:42
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@dhartunian dhartunian requested review from koorosh and vladlos January 19, 2021 15:42
@dhartunian dhartunian force-pushed the upgrade-admin-ui-components-to-cluster-ui branch 3 times, most recently from 54cef32 to acc7284 Compare January 19, 2021 22:08
Copy link
Copy Markdown
Contributor

@koorosh koorosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
CI failed with eslint error in src/app.spec.tsx file.

@dhartunian dhartunian force-pushed the upgrade-admin-ui-components-to-cluster-ui branch 2 times, most recently from ee5ecb8 to 5b8f83b Compare January 25, 2021 15:09
We renamed the `admin-ui-components` package
to `cluster-ui`.

Also removed some tslint directives that are
no longer necessary.

Release note: None
@dhartunian dhartunian force-pushed the upgrade-admin-ui-components-to-cluster-ui branch from 5b8f83b to e18ffc8 Compare January 25, 2021 18:09
@dhartunian
Copy link
Copy Markdown
Collaborator Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 25, 2021

Build succeeded:

@craig craig bot merged commit 2ec7d92 into cockroachdb:master Jan 25, 2021
@dhartunian dhartunian deleted the upgrade-admin-ui-components-to-cluster-ui branch November 14, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants