opt: fix show_trace_nonmetamorphic test#59022
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 15, 2021
Merged
Conversation
This test was broken but it wasn't obvious because it only runs 20% of the time (when the build happens to not be metamorphic). It can be forced to run using `TAGS=crdb_test_off`. Fixes cockroachdb#58989. Release note: None
Member
|
This change is |
otan
approved these changes
Jan 14, 2021
Contributor
otan
left a comment
There was a problem hiding this comment.
i'm guesing some logic underneath accepts both with and without partition_all_by =false?
Member
Author
|
No, the subtest is skipped altogether if the global metamorphic build flag is set, which happens 80% of the time. So the overall test passes 80% of the time even if there is garbage in the file. |
Member
Author
|
bors r+ |
Contributor
|
Build failed: |
Member
|
A flake. bors r+ |
Contributor
|
Build failed: |
Contributor
|
bors success rate is like 20% these days bors r+ |
Contributor
|
Build succeeded: |
Member
Author
I'm doing the best I can!! :) (I'm the test infra engineer this week) |
Contributor
|
good luck! i hope you see green salad with no tomatoes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was broken but it wasn't obvious because it only runs 20% of
the time (when the build happens to not be metamorphic). It can be
forced to run using
TAGS=crdb_test_off.Fixes #58989.
Release note: None