cli: Fix for a race condition in the teardown of demo cluster#58972
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 13, 2021
Merged
cli: Fix for a race condition in the teardown of demo cluster#58972craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes cockroachdb#58959 A change made in cockroachdb#57123 introduced a race condition into the tear down of the demo cluster. On shutdown the storage engines for some servers could get closed, before the server itself is stopped, which leads to panics in Pebble. This change makes sure that all the servers are stopped before we close the in memory sticky storage engines. Release note: None
Member
|
This change is |
tbg
approved these changes
Jan 13, 2021
Author
|
TFTR! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58959
A change made in #57123 introduced a race condition into the tear
down of the demo cluster. On shutdown the storage engines for
some servers could get closed, before the server itself is stopped,
which leads to panics in Pebble. This change makes sure that all the
servers are stopped before we close the in memory sticky storage engines.
Release note: None