kv: update replica-level tscache tests for synthetic timestamps#58903
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 13, 2021
Merged
kv: update replica-level tscache tests for synthetic timestamps#58903craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
aayushshah15
approved these changes
Jan 13, 2021
Contributor
aayushshah15
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/kv/kvserver/replica_test.go, line 2305 at r1 (raw file):
// TestReplicaUpdateTSCache verifies that reads and ranged writes update the // timestamp cache. The test performs the operatations with and without the use
operations* here and below for the other tests.
This commit updates the following three tests to confirm that synthetic timestamp information is propagated from read/ranged-write requests, through the timestamp cache, to conflicting write requests. - TestReplicaUpdateTSCache - TestReplicaUseTSCache - TestReplicaTSCacheForwardsIntentTS
c226d3e to
6b71148
Compare
nvb
commented
Jan 13, 2021
Contributor
Author
nvb
left a comment
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/kv/kvserver/replica_test.go, line 2305 at r1 (raw file):
Previously, aayushshah15 (Aayush Shah) wrote…
operations* here and below for the other tests.
Done.
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the following three tests to confirm that synthetic
timestamp information is propagated from read/ranged-write requests,
through the timestamp cache, to conflicting write requests.