sql, jobs: stop queuing schema change jobs for in-txn schema changes#58888
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 14, 2021
Merged
sql, jobs: stop queuing schema change jobs for in-txn schema changes#58888craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
ajwerner
approved these changes
Jan 14, 2021
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @postamar)
pkg/sql/logictest/testdata/logic_test/alter_table, line 1508 at r1 (raw file):
query I SELECT count(*) FROM [SHOW JOBS] WHERE job_type = 'SCHEMA CHANGE' AND description LIKE 'ALTER TABLE test.public.t45985 %'
This is potentially brittle because these strings might change. What about:
SELECT count(descriptor_id)
FROM (
SELECT json_array_elements_text(
crdb_internal.pb_to_json(
'cockroach.sql.jobs.jobspb.Payload',
payload
)->'descriptorIds'
)::INT8 AS descriptor_id
FROM system.jobs
)
WHERE descriptor_id = ('test.public.t45985'::REGCLASS)::INT8;Creating a table and changing its schema within a transaction would cause a schema change job to be queued. Such jobs are not necessary and don't do anything. This patch prevents them from being queued in the first place. Fixes cockroachdb#45985. Release note (sql change): Creating a table and changing its schema within a transaction no longer schedules a schema change job.
postamar
commented
Jan 14, 2021
Author
postamar
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/logictest/testdata/logic_test/alter_table, line 1508 at r1 (raw file):
Previously, ajwerner wrote…
This is potentially brittle because these strings might change. What about:
SELECT count(descriptor_id) FROM ( SELECT json_array_elements_text( crdb_internal.pb_to_json( 'cockroach.sql.jobs.jobspb.Payload', payload )->'descriptorIds' )::INT8 AS descriptor_id FROM system.jobs ) WHERE descriptor_id = ('test.public.t45985'::REGCLASS)::INT8;
Done.
Author
|
CI failed due to an unrelated test failure for which there is already an issue open: #58989 |
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a table and changing its schema within a transaction would
cause a schema change job to be queued. Such jobs are not necessary and
don't do anything. This patch prevents them from being queued in the
first place.
Fixes #45985.
Release note (sql change): Creating a table and changing its schema
within a transaction no longer schedules a schema change job.