server,cli: ensure the server identifiers are properly logged in SQL pds#58862
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jan 15, 2021
Merged
server,cli: ensure the server identifiers are properly logged in SQL pds#58862craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
63c42ce to
d955224
Compare
d955224 to
e6e5f14
Compare
Contributor
Author
|
Now also includes roachtest. |
60c7f02 to
ea44544
Compare
Contributor
Author
|
Nb: the |
ea44544 to
17574e7
Compare
a81818d to
a6f41ef
Compare
…pods This is a forward-port of a change we've discovered was necessary in v20.2: we want the cluster ID and other server identifiers to be reported in log files. This was not possible before. Release note: None
a6f41ef to
b483a26
Compare
itsbilal
approved these changes
Jan 14, 2021
Contributor
itsbilal
left a comment
There was a problem hiding this comment.
Reviewed 6 of 9 files at r1, 6 of 6 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @tbg)
Release note: None
Contributor
Author
|
thanks! bors r=itsbilal |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a forward-port of a change (#58708) we've discovered was necessary in v20.2.
Release note: None