ui: changed metric label CPUs to vCPUs#58495
Conversation
|
This change is |
nkodali
left a comment
There was a problem hiding this comment.
Commit messages should follow guidelines here: https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/73072807/Git+Commit+Messages.
One minor comment, but LG otherwise!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @nanduu04)
pkg/ui/src/views/cluster/containers/nodesOverview/index.tsx, line 273 at r1 (raw file):
title: ( <CPUsTooltip> vCPU
let's leave this plural "vCPUs"
350c847 to
e16e32f
Compare
updated! |
|
updated to plural vCPUs |
dhartunian
left a comment
There was a problem hiding this comment.
Can you collapse the 3 commits into one? We merge into master instead of squashing and having a clean git history is important. Once you fix this, update the PR title/description to match the one commit. (You can do this using git rebase --interactive, happy to help w/ that feature)
The commit/PR message requires the ui: prefix to denote that this is a change to the UI package and a properly formatted release note in the body (you can see how the commit hook we have already inserted templates for you to fill in).
This is important even for small changes like this one because the Release note lines are aggregated and looked at by the docs team to identify PRs that require docs changes. This one will require some docs tweaks so it's important to note that the language in the UI has changed.
Reviewable status:
e16e32f to
c644a60
Compare
|
@nanduu04 looksl ike tests are failing, can you try running |
Looks like two tests are failing. |
|
@nanduu04 great! the error messages are quite helpful, the tests are failing because of exactly the change you made. Make sure you can run the tests locally, make the fixes (the file that's failing is in the error message), and push an updated commit. |
|
@nanduu04 thx for fixing the tests. can you combine the two commits into one again? In the future you can also use |
4ca55a4 to
812fe36
Compare
|
@nanduu04 I retriggered your failing build in TC and it passes now, but there's now a merge conflict so you will need to rebase on |
812fe36 to
1b2426b
Compare
Release note (ui change): CPUs metric column renamed to vCPUs in node overview in cluster overview page.
1b2426b to
adfc35c
Compare
|
bors r+ |
|
Build succeeded: |
Release note (ui change): CPUs metric column renamed to vCPUs in node
overview in cluster overview page.