roachtest: de-flake kv/gracefuldraining#58419
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 5, 2021
Merged
Conversation
Member
Contributor
Author
|
NB: this may not be good to go yet. There's still a failure that tells me that the cluster is being shut down by the test "too early" (i.e. the nodes go down before the test completes). So we're missing an additional synchronization point. |
tbg
approved these changes
Jan 5, 2021
Member
tbg
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
d6e1df1 to
89fc07e
Compare
This test has been disabled as flaky for a while.
While it failed, we were expecting that it was denouncing a valid
problem inside CockroachDB; as it was allegedly reporting “a
performance drop during node restarts”.
However, after carefully looking at the detail of the failures, we
see:
```
QPS of 855.30 ... is below minimum allowable QPS of 900.00; entire
timeseries: [{TimestampNanos:1598976900000000000 Value:29.9}
{TimestampNanos:1598976910000000000 Value:855.3}
{TimestampNanos:1598976920000000000 Value:999.4000000000001} ... {TimestampNanos:1598977160000000000 Value:996.9000000000001}]
```
The test is failing because the *second* value is below the
threshold. If we look at multiple instances of the failure, the
symptom is always the same: the performance is quite stable *after it
stabilizes at the beginning.* However, it sometime takes more than 10
seconds (1 timeseries data point) to stabilize, whereas the test
expected at most 10 seconds (1 datapoint) of off-threshold
performance.
The problem here is that the QPS increase by the workload program can
actually last for more than a dozen seconds: beyond waiting for the
client to start, the ranges need to spread the traffic, the metric can
lag, etc.
To address this problem in the design of the test, this commit changes
the sequence of checks to *initially* (before the first node restart)
wait for the workload QPS to stabilize, and *only then* restart nodes
gracefully and expect the performance to remain stable.
Release note: None
89fc07e to
dc03d6c
Compare
Contributor
Author
|
TFYR! bors r=tbg |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53760
Fixes #53725
Fixes #54088
Fixes #53811
This test has been disabled as flaky for a while.
While it failed, we were expecting that it was denouncing a valid
problem inside CockroachDB; as it was allegedly reporting “a
performance drop during node restarts”.
However, after carefully looking at the detail of the failures, we
see:
The test is failing because the second value is below the
threshold. If we look at multiple instances of the failure, the
symptom is always the same: the performance is quite stable after it
stabilizes at the beginning. However, it sometime takes more than 10
seconds (1 timeseries data point) to stabilize, whereas the test
expected at most 10 seconds (1 datapoint) of off-threshold
performance.
The problem here is that the QPS increase by the workload program can
actually last for more than a dozen seconds: beyond waiting for the
client to start, the ranges need to spread the traffic, the metric can
lag, etc.
To address this problem in the design of the test, this commit changes
the sequence of checks to initially (before the first node restart)
wait for the workload QPS to stabilize, and only then restart nodes
gracefully and expect the performance to remain stable.
Release note: None