sqlproxyccl: always close the client connection#58355
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 30, 2020
Merged
sqlproxyccl: always close the client connection#58355craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Previously, the sqlproxy failed to close the incoming TCP connection if an error occurred in the frontend admitter. This leaked the connection server-side and left the client connection hanging. This adds back the deferred close of the incoming TCP connection (removed in cockroachdb#57306). The custom Conn type allows callers to call Close multiple times. Release note: none
028d1dc to
be8c5cf
Compare
Contributor
Author
|
TFTR! bors r=darinpp |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the sqlproxy failed to close the incoming TCP connection if
an error occurred in the frontend admitter. This leaked the connection
server-side and left the client connection hanging.
This adds back the deferred close of the incoming TCP connection
(removed in #57306). The custom Conn type allows callers to call Close
multiple times.
Release note: none