sql/rowexec: don't allocate buf per row in sketchInfo.addRow#58117
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 21, 2020
Merged
sql/rowexec: don't allocate buf per row in sketchInfo.addRow#58117craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The `intbuf` array was meant to stay on the stack, but was escaping to the heap because the call through the `hash` function variable was opaque to escape analysis. At the end of a 4 hour, 2.2 TB IMPORT of TPC-E, this was responsible for **76.70%** of all heap allocations.
Member
|
This change is |
Member
|
Wow, nice find! LGTM! Can you backport to both 20.1 and 20.2? |
Contributor
Author
Sure! bors r+ |
Contributor
|
Build succeeded: |
This was referenced Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
intbufarray was meant to stay on the stack, but was escaping to the heap because the call through thehashfunction variable was opaque to escape analysis.At the end of a 4 hour, 2.2 TB IMPORT of TPC-E, this was responsible for 76.70% of all heap allocations (by object).