Skip to content

roachtest: add test_9_6_diagnostics to psycopg blocklist#58036

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
arulajmani:psycopg-blocklist
Dec 18, 2020
Merged

roachtest: add test_9_6_diagnostics to psycopg blocklist#58036
craig[bot] merged 1 commit intocockroachdb:masterfrom
arulajmani:psycopg-blocklist

Conversation

@arulajmani
Copy link
Copy Markdown
Collaborator

@arulajmani arulajmani commented Dec 17, 2020

Previously, this test was skipped as our pg server version (9.5) did
not meet the threshold (9.6) for this test to run. After the pg server
version bump to 13 this is no longer the case. A change to explicitly
skip this test for CRDB has been merged upstream, but it won't apply
until the next release (psycopg_2_8_7) comes out and we switch to
testing against that. Until then, this test lives in the blocklist.

Closes #57986

Release note: None

@arulajmani arulajmani requested a review from rafiss December 17, 2020 17:05
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Previously, this test was skipped as our pg server version (9.5) did
not meet the threshold (9.6) for this test to run. After the pg server
version bump to 13 this is no longer the case. A change to explicitly
skip this test for CRDB has been merged upstream, but it won't apply
until the next release (psycopg_2_8_7) comes out and we switch to
testing against that. Until then, this test lives in the blocklist.

Closes cockroachdb#57986

Release note: None
Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@arulajmani
Copy link
Copy Markdown
Collaborator Author

TFTR!

bors r=rafiss

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 18, 2020

Build succeeded:

@craig craig bot merged commit 05da184 into cockroachdb:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: psycopg failed

3 participants