eventpb: new JSON serialization with redaction markers#57990
eventpb: new JSON serialization with redaction markers#57990craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
719b601 to
92bc29a
Compare
|
This change is |
5bee92b to
8e2c2f2
Compare
8e2c2f2 to
d2318da
Compare
d2318da to
ba9e26d
Compare
76a294d to
e265fcf
Compare
itsbilal
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 8 of 8 files at r2, 20 of 20 files at r3.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @knz)
docs/generated/eventlog.md, line 1241 at r3 (raw file):
### Common fields | Field | Description | Sensitive |
Is there room to clarify what sensitive means, somewhere near the top of this file? At first I was slightly confused as it could also mean "case sensitive" when in reality it's redaction/PII sensitive. Maybe I'm thinking too much, feel free to ignore this point.
This patch introduces a new code generator and infrastructure to emit structured event payloads using the JSON syntax, but also including redaction markers for fields not marked explicitly as safe for reporting. This is not yet connected to the remainder of the logging system -- this change will be performed in a later commit. Release note: None
e265fcf to
cb1a2ce
Compare
knz
left a comment
There was a problem hiding this comment.
Reviewable status:
docs/generated/eventlog.md, line 1241 at r3 (raw file):
Previously, itsbilal (Bilal Akhtar) wrote…
Is there room to clarify what
sensitivemeans, somewhere near the top of this file? At first I was slightly confused as it could also mean "case sensitive" when in reality it's redaction/PII sensitive. Maybe I'm thinking too much, feel free to ignore this point.
Good idea. Done.
|
TFYR! bors r=itsbilal |
|
Build succeeded: |
Fixes #45643
All commits but the last from #58070 and prior
This is a prereq for presenting structured events "inline" in #57170.
This patch introduces a new code generator and infrastructure to emit
structured event payloads using the JSON syntax, but also including
redaction markers for fields not marked explicitly as safe for
reporting.
This is not yet connected to the remainder of the logging system --
this change will be performed in a later commit.
Release note: None