server: fix decomm status replica overcounting for r1#57812
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 11, 2020
Merged
server: fix decomm status replica overcounting for r1#57812craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
When scanning the KV keyspace for all range descriptors, we want to scan from Meta2Prefix to MetaMax (see meta2RangeIter for other usages of this). In our decomm status codepaths we were erroneously starting off our scan at MetaMin, so including meta1 in our scans as well. This has the effect of iterating over the range descriptor for r1 twice (first observed in cockroachdb#57650 where we cargo-culted these bounds). Release note (bug fix): When displaying replica counts during the decommissioning process, previously we were overcounting the replicas displayed for r1. This is no longer the case.
Member
|
This change is |
knz
approved these changes
Dec 11, 2020
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @tbg)
Contributor
Author
|
TFTR! Looks like CI is red due to the registration server crapping out, I'll pick it up after. |
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scanning the KV keyspace for all range descriptors, we want to scan
from Meta2Prefix to MetaMax (see meta2RangeIter for other usages of
this). In our decomm status codepaths we were erroneously starting off
our scan at MetaMin, so including meta1 in our scans as well. This has
the effect of iterating over the range descriptor for r1 twice (first
observed in #57650 where we cargo-culted these bounds).
Release note (bug fix): When displaying replica counts during the
decommissioning process, previously we were overcounting the
replicas displayed for r1. This is no longer the case.