colexec: fix jsonb - string projection#57349
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 2, 2020
Merged
Conversation
Member
|
This change is |
d8628d1 to
9c9bc68
Compare
asubiotto
approved these changes
Dec 2, 2020
Contributor
asubiotto
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
pkg/sql/colexec/execgen/cmd/execgen/overloads_bin.go, line 813 at r1 (raw file):
// JSONFetchVal) and both require the value to be of String type, so we // perform such conversion. // In order to mistakenly not add support for another binary operator in
nit: move this paragraph (starting from In order into the following case)
Bytes canonical type family represents several types, and whenever we're performing a binary operation with one datum and one non-datum arguments we need to convert the latter to the correct datum type. Previously, we had an incorrect conversion for Minus operation. Release note (bug fix): Previously, CockroachDB would encounter an internal error when performing `JSONB - String` operation via the vectorized execution engine, and this has been fixed. The bug was introduced in 20.2.0 version.
9c9bc68 to
8549464
Compare
yuzefovich
commented
Dec 2, 2020
Member
Author
yuzefovich
left a comment
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bytes canonical type family represents several types, and whenever we're
performing a binary operation with one datum and one non-datum arguments
we need to convert the latter to the correct datum type. Previously, we
had an incorrect conversion for Minus operation.
Fixes: #57165.
Release note (bug fix): Previously, CockroachDB would encounter an
internal error when performing
JSONB - Stringoperation via thevectorized execution engine, and this has been fixed. The bug was
introduced in 20.2.0 version.