clusterversion: reduce stuttering in package API#57338
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 2, 2020
Merged
clusterversion: reduce stuttering in package API#57338craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
d96eca7 to
1d418d9
Compare
knz
approved these changes
Dec 2, 2020
Contributor
knz
left a comment
There was a problem hiding this comment.
Reviewed 46 of 46 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @irfansharif and @tbg)
pkg/server/updates_test.go, line 150 at r1 (raw file):
} } // ListBetween 10 and 100 queries is quantized to 10.
Please revert this file.
tbg
approved these changes
Dec 2, 2020
1d418d9 to
54f23c5
Compare
irfansharif
commented
Dec 2, 2020
Contributor
Author
irfansharif
left a comment
There was a problem hiding this comment.
TFTRs!
Reviewable status:
pkg/server/updates_test.go, line 150 at r1 (raw file):
Previously, knz (kena) wrote…
Please revert this file.
Woops, done.
Contributor
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
This package was extracted out of pkg/settings/cluster in cockroachdb#45455. Now that we're coupling it tightly with our migrations infrastructure (pkg/migration), let's remove some unnecessary stuttering for ease of use. ```diff - if <settings handle>.Version.IsActive(ctx, clusterversion.VersionSomething) { + if <settings handle>.Version.IsActive(ctx, clusterversion.Something) { ``` All the diffs here are just mechanical goland-renames. Release note: None
54f23c5 to
3230734
Compare
Contributor
|
Canceled. |
Contributor
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package was extracted out of pkg/settings/cluster in #45455. Now
that we're coupling it tightly with our migrations infrastructure
(pkg/migration), let's remove some unnecessary stuttering for ease of
use.
All the diffs here are just mechanical goland-renames.
Release note: None