execinfra/sql: return ContentionEvents through ProducerMetadata and add metric#57298
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Dec 2, 2020
asubiotto:cont-recv
Merged
execinfra/sql: return ContentionEvents through ProducerMetadata and add metric#57298craig[bot] merged 2 commits intocockroachdb:masterfrom asubiotto:cont-recv
craig[bot] merged 2 commits intocockroachdb:masterfrom
asubiotto:cont-recv
Conversation
Member
|
This change is |
RaduBerinde
approved these changes
Dec 1, 2020
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
Contributor
Author
|
Getting an issue because the new metric is not present in the chart catalog. Do I want it to be? I'm not sure what this means. I'll look into it tomorrow. |
This allows remote components to send back contention events through the metadata protobuf. Release note: None
…metric This commit changes KV layer-aware components to return any ContentionEvents produced by the KV layer through metadata. Returning ContentionEvents in write transactions is left for a future commit. A global contention timeseries metric is also added and incremented at most once per query by the distsql receiver if at least one contention event is encountered. Release note: None (change is not observable by the user)
Contributor
Author
|
TFTR bors r=RaduBerinde |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details. This PR adds a
sql.distsql.contended_queries.countmetric that is incremented if a query produces at least one contention event.Release note: None
Closes #56798