sql: raise error if opaque statement receives nil plan node#57263
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 1, 2020
Merged
sql: raise error if opaque statement receives nil plan node#57263craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously there was no check for a situation in which a planNode was nil. For opaque statements, this resulted in occasional panics when a nil planNode was returned. This commit adds a check for opaque statements to make sure the planNode is not nil before moving on to execution. Release note: None
Member
|
This change is |
RaduBerinde
approved these changes
Dec 1, 2020
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @otan and @RaduBerinde)
otan
approved these changes
Dec 1, 2020
Author
|
bors r=RaduBerinde |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #56861.
Previously there was no check for a situation in which a planNode
was nil. For opaque statements, this resulted in occasional panics
when a nil planNode was returned. This commit adds a check for
opaque statements to make sure the planNode is not nil before
moving on to execution.
Release note: None