rowenc: de-flake TestEncodeContainingArrayInvertedIndexSpans#57246
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 30, 2020
Merged
Conversation
`TestEncodeContainingArrayInvertedIndexSpans` was failing sporadically because of randomized test cases that were incorrectly determining the expected value for the `unique` return value from `EncodeContainingInvertedIndexSpans`. The test was using the `reflect.DeepEqual` function to check for `Datum` equality, which does not return true in all cases where `Datum.Compare` returns `0`. Fixes cockroachdb#57237 Release note: None
Member
|
This change is |
rytaft
approved these changes
Nov 30, 2020
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Nice find!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Contributor
Author
|
bors r=rytaft |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestEncodeContainingArrayInvertedIndexSpanswas failing sporadicallybecause of randomized test cases that were incorrectly determining the
expected value for the
uniquereturn value fromEncodeContainingInvertedIndexSpans. The test was using thereflect.DeepEqualfunction to check forDatumequality, which doesnot return true in all cases where
Datum.Comparereturns0.Fixes #57237
Release note: None