ccl/sqlproxyccl: lazily initialize closedCh#57233
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 1, 2020
Merged
ccl/sqlproxyccl: lazily initialize closedCh#57233craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Lazily initialize `sqlproxyccl.Conn`'s `closedCh`. This avoids allocating a channel when it's not needed and allows package consumers to construct their own `sqlproxyccl.Conn`s without needing access to the unexported `closedCh` member field. Release note: None
Member
|
This change is |
petermattis
approved these changes
Dec 1, 2020
Collaborator
petermattis
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @petermattis and @spaskob)
jbowens
commented
Dec 1, 2020
Contributor
Author
jbowens
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status:
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazily initialize
sqlproxyccl.Conn'sclosedCh. This avoidsallocating a channel when it's not needed and allows package consumers
to construct their own
sqlproxyccl.Conns without needing access to theunexported
closedChmember field.